Skip to content

ci: Make able to run workflow in forks with uppercase in names #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxymVlasov merged 9 commits into from
Jan 25, 2025
Merged

ci: Make able to run workflow in forks with uppercase in names #782

MaxymVlasov merged 9 commits into from
Jan 25, 2025

Conversation

@MaxymVlasov
Copy link
Collaborator

@MaxymVlasov MaxymVlasov commented Jan 24, 2025

Description of your changes

Deal with

ERROR: invalid tag "ghcr.io/MaxymVlasov/pre-commit-terraform-712:latest": repository name must be lowercase

Found during testing changes for #712 - as I need to test all workflows without disrupting main repo

@MaxymVlasov MaxymVlasov force-pushed the chore/better_forks_support branch from 78bdc29 to 50709ee Compare January 24, 2025 22:55
@MaxymVlasov MaxymVlasov marked this pull request as draft January 24, 2025 22:59
@MaxymVlasov
Copy link
Collaborator Author

MaxymVlasov commented Jan 24, 2025 •
edited
Loading

I don't get why it fails here.
UPD. So that's the issue - https://github.com/orgs/community/discussions/25768#discussioncomment-10671432

@MaxymVlasov MaxymVlasov marked this pull request as ready for review January 24, 2025 23:22
@yermulnik
Copy link
Collaborator

yermulnik commented Jan 24, 2025

I don't get why it fails here. UPD. So that's the issue - github.com/orgs/community/discussions/25768#discussioncomment-10671432

I guess the linked comment is only somewhat correct.
Try and add shell: bash to run block to ensure it runs bash rather than Ubuntu's default shell which is dash I guess (and which is pretty much POSIX'ish).

Also the simpler tolowercase in Bash is ${VER,,}. JFYI.

yermulnik
yermulnik reviewed Jan 24, 2025
View reviewed changes
MaxymVlasov
MaxymVlasov commented Jan 25, 2025
View reviewed changes
@MaxymVlasov @yermulnik
Apply suggestions from code review
334134e 
Co-authored-by: George L. Yermulnik <[email protected]>
MaxymVlasov
MaxymVlasov commented Jan 25, 2025
View reviewed changes
MaxymVlasov
MaxymVlasov commented Jan 25, 2025
View reviewed changes
MaxymVlasov
MaxymVlasov commented Jan 25, 2025
View reviewed changes
MaxymVlasov
MaxymVlasov commented Jan 25, 2025
View reviewed changes
MaxymVlasov
MaxymVlasov commented Jan 25, 2025
View reviewed changes
MaxymVlasov
MaxymVlasov commented Jan 25, 2025
View reviewed changes
@MaxymVlasov MaxymVlasov merged commit e7d51db into antonbabenko:master Jan 25, 2025
39 checks passed
@MaxymVlasov MaxymVlasov deleted the chore/better_forks_support branch January 25, 2025 18:05
@antonbabenko
Copy link
Owner

antonbabenko commented Feb 1, 2025

This PR is included in version 1.97.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yermulnik yermulnik yermulnik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxymVlasov @yermulnik @antonbabenko